Metric threshold rules for custom reports #34

Merged

Gilles merged 20 commits from feat/23-metric-thresholds into master 2026-10-28 22:53:30 +00:00

Conversation 1 Commits 20 Files changed 9 +324 -24

Gilles commented 2026-10-28 15:34:06 +00:00

Owner

• Copy link
• Copy Markdown

Closes #23

Part of the server monitoring plan (phase 2.2). Stacked on #33 (base feat/29-stale-trigger).

Changes

• Trigger.METRIC_THRESHOLD ("Seuil sur une métrique", default severity warning). Params validated by the rule API: key (required), operator (>, >=, <, <=, default >=), warn and/or fail (at least one).
• New apps.events.thresholds: metric lookup by key (falls back to the label), level computation, and apply().
• process_report (custom reports only): matching enabled rules raise each metric's status, the report's status and summary.status to the worst of sender and rules — never lowered — before de-duplication and aggregation, so badges and aggregate status reflect it.
• Event: fires when the computed level goes up (ok → warn, warn → fail, ok → fail), with a message like disk_pct = 85% >= 80%; dropping back re-arms it (state in EventRuleState.last_status).
• README, feature catalog; tests in apps/events/test_thresholds.py.

Checks

pytest (219 passed), pylint 10/10, autopep8, bandit clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_014BSmBtGWeFBD9z4mYm9SjA

Closes #23 Part of the server monitoring plan (phase 2.2). **Stacked on #33** (base `feat/29-stale-trigger`). ## Changes - `Trigger.METRIC_THRESHOLD` ("Seuil sur une métrique", default severity warning). Params validated by the rule API: `key` (required), `operator` (`>`, `>=`, `<`, `<=`, default `>=`), `warn` and/or `fail` (at least one). - New `apps.events.thresholds`: metric lookup by `key` (falls back to the label), level computation, and `apply()`. - `process_report` (custom reports only): matching enabled rules raise each metric's `status`, the report's status and `summary.status` to the worst of sender and rules — never lowered — **before** de-duplication and aggregation, so badges and aggregate status reflect it. - Event: fires when the computed level goes up (ok → warn, warn → fail, ok → fail), with a message like `disk_pct = 85% >= 80%`; dropping back re-arms it (state in `EventRuleState.last_status`). - README, feature catalog; tests in `apps/events/test_thresholds.py`. ## Checks pytest (219 passed), pylint 10/10, autopep8, bandit clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_014BSmBtGWeFBD9z4mYm9SjA

Gilles added the

feature

label 2026-10-28 15:34:06 +00:00

Gilles added 1 commit 2026-10-28 15:34:06 +00:00

feature: metric threshold rules for custom reports ... e6dec8df33

- New report-level trigger metric_threshold: a metric found by its
  stable `key` (or label), an operator and warn and/or fail thresholds.
- Matching enabled rules are applied while a custom report is
  processed: the metric's and the report's status become the worst of
  the sender's and the rules' (never lowered), so badges and aggregates
  follow.
- The event fires when the computed level goes up (ok -> warn,
  warn -> fail, ok -> fail); going back down re-arms it.

Closes #23

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014BSmBtGWeFBD9z4mYm9SjA

Gilles referenced this pull request 2026-10-28 15:40:30 +00:00

Organization-level and global event rules #35

Gilles commented 2026-10-28 15:41:44 +00:00

Author

Owner

• Copy link
• Copy Markdown

📊 Rapports Argus pour cette PR

<!-- argus-link-bot:argus/backend --> 📊 [Rapports Argus pour cette PR](https://reports.stationmyr.net/argus/backend/pr/34)

Gilles referenced this pull request from argus/frontend 2026-10-28 15:50:16 +00:00

Rule editor: silent-source and metric-threshold triggers #23

Gilles added 1 commit 2026-10-28 18:35:32 +00:00

Merge branch 'feat/29-stale-trigger' into feat/23-metric-thresholds bdbd489a1f

Gilles added 1 commit 2026-10-28 19:25:53 +00:00

Merge branch 'feat/29-stale-trigger' into feat/23-metric-thresholds f6d211fa96

Gilles added 1 commit 2026-10-28 19:26:27 +00:00

Merge branch 'feat/29-stale-trigger' into feat/23-metric-thresholds 1a0f2cafbe

Gilles added 1 commit 2026-10-28 22:34:52 +00:00

Merge branch 'feat/29-stale-trigger' into feat/23-metric-thresholds 8f0862a70d

Gilles changed target branch from feat/29-stale-trigger to master 2026-10-28 22:46:09 +00:00

Gilles added 1 commit 2026-10-28 22:47:01 +00:00

Merge remote-tracking branch 'origin/master' into feat/23-metric-thresholds ... 4c67cb0bee

# Conflicts:
#	README.md
#	apps/events/engine.py
#	apps/events/models.py
#	apps/events/serializers.py
#	e2e/features.catalog.yaml

Gilles scheduled this pull request to auto merge when all checks succeed 2026-10-28 22:47:19 +00:00

Gilles scheduled this pull request to auto merge when all checks succeed 2026-10-28 22:47:29 +00:00

Gilles merged commit a153f2a13b into master 2026-10-28 22:53:30 +00:00

Gilles deleted branch feat/23-metric-thresholds 2026-10-28 22:53:31 +00:00

Gilles referenced this pull request from a commit 2026-10-28 22:53:33 +00:00

Metric threshold rules for custom reports (#34)

Gilles referenced this pull request from a commit 2026-10-29 06:59:47 +00:00

Rule editor: silent-source and metric-threshold triggers (#23)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

breaking

Breaking change: listed first in the release notes

  

bug

Bug fix (release notes: Bug fixes)

  

ci

CI and maintenance (release notes: CI & maintenance)

  

dependencies

Dependency update (release notes: Dependencies, folded)

  

documentation

Documentation (release notes: Documentation)

  

feature

New feature (release notes: Features)

  

security

Security fix (release notes: Security)

  

skip-changelog

Left out of the release notes

No labels

breaking

bug

ci

dependencies

documentation

feature

security

skip-changelog

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

argus/backend!34

No description provided.